Fix exceptions handling in task dynamic invocation#360
Merged
Conversation
TheAngryByrd
added a commit
that referenced
this pull request
Jun 2, 2026
- BREAKING: [Move `ValueTaskValueOption` to the IcedTasks package](#363) Credits @TheAngryByrd - This was misplaced originally as it depends on IcedTasks since it's using valueTasks. If you were using this before, add FsToolkit.ErrorHandling.IcedTasks as a dependency. - [Add `partitionResults` with single-pass implementations for Array, List, and Seq](#359) Credits @bpe-incom - [Fix exception handling in task dynamic invocation](#360) Credits Eugene Auduchinok - [Improve performance of task applicative helpers, array traversal helpers, option workflows, and list task traversal](#364) Credits @TheAngryByrd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes task handling when dynamic invocations are used.
The context is I'm working on dotnet/fsharp#19548 which improves debugging experience by preventing inlining where possible and allowing stepping into inline functions and setting breakpoints there. This makes the compiler produce the dynamic invocations instead of the state machines, and this uncovered exceptions in FsToolkit.ErrorHandling tests.